Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

screenshots in system tests #5868

Merged
merged 7 commits into from
Jun 12, 2019
Merged

screenshots in system tests #5868

merged 7 commits into from
Jun 12, 2019

Conversation

jywarren
Copy link
Member

Re #5320 but squashed!

@jywarren jywarren mentioned this pull request Jun 11, 2019
Closed
jywarren
jywarren commented Jun 11, 2019
View reviewed changes
containers/docker-compose-testing.yml
- CI=${CI}
- TRAVIS=${TRAVIS}
- CONTINUOUS_INTEGRATION=${CONTINUOUS_INTEGRATION}
- HAS_JOSH_K_SEAL_OF_APPROVAL=${HAS_JOSH_K_SEAL_OF_APPROVAL}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just for demonstration purposes, @icarito ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember off the top of my head why HAS_JOSH_K_SEAL_OF_APPROVAL is needed but it is no invention of mine and it seems some libs check for it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.travis-ci.com/user/environment-variables/

@plotsbot
Copy link
Collaborator

plotsbot commented Jun 11, 2019 •
edited
Loading

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

5868-test_wiki.png

5868-test_tags.png

5868-test_people.png

5868-test_blog.png

5868-test_front_page_with_navbar_search_autocomplete.png

5868-test_viewing_the_dashboard.png

Generated by 🚫 Danger

@jywarren
Copy link
Member Author

Ohhhhh so this will only work on PRs on publiclab's account?

@jywarren
Copy link
Member Author

Ok, so my fork doesn't have access to publiclab's environment variables.

https://docs.travis-ci.com/user/environment-variables/#encrypting-environment-variables

@jywarren
Copy link
Member Author

Signed Policy Documents: Specify what can be uploaded to a bucket. Policy documents allow greater control over size, content type, and other upload characteristics than signed URLs, and can be used by website owners to allow visitors to upload files to Cloud Storage.

https://cloud.google.com/storage/docs/access-control/

https://cloud.google.com/storage/docs/xml-api/post-object#policydocument

@jywarren
Copy link
Member Author

https://stackoverflow.com/questions/25158266/how-to-allow-anonymous-uploads-to-cloud-storage

@jywarren
Copy link
Member Author

Huh...

[Screenshot]: tmp/screenshots/failures_test_posting_from_the_editor.png
ERROR["test_posting_from_the_editor", #<Minitest::Reporters::Suite:0x000055c95609e8e8 @name="PostTest">, 74.22745889599992]
 test_posting_from_the_editor#PostTest (74.23s)
Capybara::ElementNotFound:         Capybara::ElementNotFound: Unable to find field "Title" that is not disabled
            test/system/post_test.rb:17:in `block in <class:PostTest>'

Could be timing related... I rebooted system tests!

@jywarren
Copy link
Member Author

Whoa, this passed tests and all, but no uploads?

@jywarren
Copy link
Member Author

Hmm...



1.40s$ if [ $TRAVIS_PULL_REQUEST != "false" ]; then docker-compose exec web danger --verbose; fi
WARNING: The SECRET_KEY_BASE variable is not set. Defaulting to a blank string.
WARNING: The GITHUB_ACTION variable is not set. Defaulting to a blank string.
WARNING: The GITHUB_TOKEN variable is not set. Defaulting to a blank string.
WARNING: The GITHUB_REPOSITORY variable is not set. Defaulting to a blank string.
WARNING: The GITHUB_EVENT_PATH variable is not set. Defaulting to a blank string.
WARNING: The GITHUB_EVENT_NAME variable is not set. Defaulting to a blank string.
Not a GitHubActions Pull Request - skipping `danger` run.
The command "if [ $TRAVIS_PULL_REQUEST != "false" ]; then docker-compose exec web danger --verbose; fi" exited with 0.

@jywarren
Copy link
Member Author

Uh, ok - symfony/panther#66 (comment), https://blog.travis-ci.com/august-2012-upcoming-ci-environment-updates/

HAS_JOSH_K_SEAL_OF_APPROVAL is necessary to show we are in Travis environment. Weird.

@jywarren
Copy link
Member Author

I changed it so if it can't find the JUnit reports, it just warns, doesn't fail.

@jywarren jywarren merged commit 9c979c6 into publiclab:master Jun 12, 2019
@jywarren jywarren mentioned this pull request Jun 12, 2019
Closed
13 tasks
jywarren added a commit that referenced this pull request Jun 12, 2019
@jywarren
add screenshots for grids
d00aa5d 
Re #5320 #5868 #5316
@jywarren jywarren mentioned this pull request Jun 12, 2019
Merged
jywarren added a commit that referenced this pull request Jun 12, 2019
@jywarren
add screenshots for grids (#5878)
b1f46a3 
* add screenshots for grids

Re #5320 #5868 #5316

* adjust screenshot path
rarrunategu1 pushed a commit to rarrunategu1/plots2 that referenced this pull request Jun 14, 2019
@jywarren @rarrunategu1
add screenshots for grids (publiclab#5878)
f960571 
* add screenshots for grids

Re publiclab#5320 publiclab#5868 publiclab#5316

* adjust screenshot path
sagarpreet-chadha pushed a commit that referenced this pull request Jun 29, 2019
@jywarren @sagarpreet-chadha
screenshots in system tests (#5868)
afc29e8 
* screenshots in system tests

* more screenshots

* Google::Cloud::Storage.anonymous

* Update Dangerfile

* Update docker-compose-testing.yml

* HAS_JOSH_K_SEAL_OF_APPROVAL

* change fail to warn in danger junit parsing

so if all tests pass, we don't worry
sagarpreet-chadha pushed a commit that referenced this pull request Jun 29, 2019
@jywarren @sagarpreet-chadha
add screenshots for grids (#5878)
1aa9062 
* add screenshots for grids

Re #5320 #5868 #5316

* adjust screenshot path
enviro3 pushed a commit to enviro3/plots2 that referenced this pull request Aug 15, 2019
@jywarren @enviro3
screenshots in system tests (publiclab#5868)
db0948a 
* screenshots in system tests

* more screenshots

* Google::Cloud::Storage.anonymous

* Update Dangerfile

* Update docker-compose-testing.yml

* HAS_JOSH_K_SEAL_OF_APPROVAL

* change fail to warn in danger junit parsing

so if all tests pass, we don't worry
enviro3 pushed a commit to enviro3/plots2 that referenced this pull request Aug 15, 2019
@jywarren @enviro3
add screenshots for grids (publiclab#5878)
1f1ccf1 
* add screenshots for grids

Re publiclab#5320 publiclab#5868 publiclab#5316

* adjust screenshot path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icarito icarito icarito left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jywarren @plotsbot @icarito